Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve feedback for oauth errors. #888

Merged
merged 1 commit into from
May 17, 2021
Merged

Improve feedback for oauth errors. #888

merged 1 commit into from
May 17, 2021

Conversation

aklajnert
Copy link
Contributor

This is a minor improvement with the feedback during the OAuth dance errors.
I got bitten by it twice, a few months apart and spent some time debugging what's going on. In my case, I got just the KeyError exception that the oauth_token key does not exist. In my case, the response dict content was as below:

{"oauth_problem": "consumer_key_unknown"}

This PR should cause the OAuth dance to return a bit more meaningful error messages during that stage.

@aklajnert aklajnert requested a review from ssbarnea January 17, 2020 18:12
@ssbarnea ssbarnea closed this May 15, 2021
@ssbarnea ssbarnea reopened this May 15, 2021
@adehad
Copy link
Contributor

adehad commented May 15, 2021

@aklajnert if you could merge the latest master and run tox -e lint, that should autoformat this correctly for it to be ready to merge.

@ssbarnea
Copy link
Member

@adehad Based on my experience many contributors will not bother to fix their older PRs. You can decide to manually implement the same fix yourself if you find it useful and close original PR. Keep in mind to add me as reviewer once it reports green.

ssbarnea
ssbarnea requested changes May 15, 2021
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI reported issues

@ssbarnea
Copy link
Member

Something is clearly not correct with this change as I see a huge number of reformatted files. It was not correctly rebased from master?

@aklajnert aklajnert force-pushed the handle_oauth_dance_errors branch from 1021e38 to aafd005 Compare May 16, 2021 11:04
@aklajnert
Copy link
Contributor Author

Something is clearly not correct with this change as I see a huge number of reformatted files. It was not correctly rebased from master?

Yeah, sorry - I did struggle with the rebase, and after I did that I had to leave. I've fixed it now.

@ssbarnea ssbarnea self-requested a review May 16, 2021 15:18
@ssbarnea ssbarnea closed this May 16, 2021
@ssbarnea ssbarnea reopened this May 16, 2021
@ssbarnea ssbarnea merged commit 203a3ca into pycontribs:master May 17, 2021
@aklajnert aklajnert deleted the handle_oauth_dance_errors branch May 17, 2021 07:53
svermeulen pushed a commit to svermeulen/jira that referenced this pull request Oct 31, 2021
@aklajnert @svermeulen
Improve feedback for oauth errors. (pycontribs#888)
9125b7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aklajnert @adehad @ssbarnea